Add BC240 TofLUT for DREAM #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for McStas simulation files shared by Celine.
SimonHeybrock
commented
Jun 20, 2025
| Note that the phase of the band-control chopper (BCC) was set to 240 degrees to | ||
| match that of the simulated data (this has since been found to be non-optimal as it | ||
| leads to time overlap between the two frames). | ||
Member
Author
There was a problem hiding this comment.
This docstring claims the old file was for 240 degrees already, but @celinedurniak mentioned on Slack it is 215. @nvaytet do you remember the history of this?
Member
There was a problem hiding this comment.
I think I it's simply that the old docstring is wrong
Member
|
Note that I believe it is not the plan for dream to switch between 215 and 240, but more to settle on which one is best and just have that as the 'high flux'. But still useful to be able to switch between the two while we are still on the development stage |
nvaytet
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for McStas simulation files shared by Celine.