Add __delitem__ #15
Merged
Add __delitem__ #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In line with how __getitem__ and __setitem__ work this cuts off the branch "held" by the key, as well as removing the node data. As discussed elsewhere the method naming is unusual, but if we intend to change this it should be done elsewhere, after more thorough thinking about the whole set of methods.
jl-wynen
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with how getitem and setitem work this cuts off the branch "held" by the key, as well as removing the node data.
As discussed elsewhere the method naming is unusual, but if we intend to change this it should be done elsewhere, after more thorough thinking about the whole set of methods.