-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add lower bound nightly test #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python.version }} | ||
| - run: python -m pip install --upgrade uv pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor]
[test] environment should already have pytest... I think...? So maybe no need to install pytest here.
YooSunYoung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| ESS_PROTECTED_FILESTORE_PASSWORD: ${{ secrets.ESS_PROTECTED_FILESTORE_PASSWORD }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better use https://github.com/astral-sh/setup-uv It's a bit odd to run uv from within a python env. (Although possible)
You should then be able to use
- run: uv run --extra=test --resolution=lowest-direct pytest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nice, thanks
|
Right now we typically don't have lower bounds on our dependencies. To make the lower bound tests pass we need to set some lower pin on most of our dependencies because otherwise some of them resolve to something ridiculous like It's hard to find the true "lower bound" combination of all dependencies that passes the tests (an interesting problem though) but in practice I think it makes sense to just set all bounds to something like the latest release at least 1-2 years old, and if it doesn't pass the tests there then manually fiddle until the tests pass. For example, here is a combination of lower pins I found that lets the |
|
Interesting, that
That sounds reasonable. We don't need to support multi-year-old dependencies. SO just picking a version as you described should work well. |
jl-wynen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you deploy this to a project and ran CI?
No I just tested it locally first. I'll try it in the CI in a few minutes, see scipp/essdiffraction#189. |
It might be constrained by other dependencies already, for example maybe sciline has a lower pin. I'm not sure. |
|
The workflow ran in essdiffraction: https://github.com/scipp/essdiffraction/actions/runs/16293424662/job/46008694444 (the regular tests fail there, but that is unrelated) |
jl-wynen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move the job into a separate file as discussed on Slack?
Fixes scipp/plopp#463
Suggested solution based on comment by @jl-wynen