FIX incorporate resampling when computing OOB score in BRF#656
Merged
glemaitre merged 3 commits intoscikit-learn-contrib:masterfrom Dec 5, 2019
Merged
FIX incorporate resampling when computing OOB score in BRF#656glemaitre merged 3 commits intoscikit-learn-contrib:masterfrom
glemaitre merged 3 commits intoscikit-learn-contrib:masterfrom
Conversation
|
Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-12-05 12:42:56 UTC |
|
This pull request fixes 5 alerts when merging e4143a0 into 3839df1 - view on LGTM.com fixed alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #655
Resampling was not taken into account when computing the OOB score. Thus, the results was incorparting in-sample and leading to over-optimistic results.