[MRG] discrete branch: add an example for KBinsDiscretizer#9713
Closed
qinhanmin2014 wants to merge 3 commits intoscikit-learn:discretefrom
qinhanmin2014:my-feature-1
Closed
[MRG] discrete branch: add an example for KBinsDiscretizer#9713qinhanmin2014 wants to merge 3 commits intoscikit-learn:discretefrom qinhanmin2014:my-feature-1
qinhanmin2014 wants to merge 3 commits intoscikit-learn:discretefrom
qinhanmin2014:my-feature-1
Conversation
Contributor
|
I addressed your question regarding more convincing datasets in #9339. |
7 tasks
Member
Author
|
ping @jnothman Sorry to disturb. |
Member
|
As I've said, I don't think this is compelling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9339
Part of #9342
What does this implement/fix? Explain your changes.
Basic idea of the example:
(1)plot the data before and after discretization (idea come from this page))
(2)train several classifiers and compare the results through cross validation. The experiment is based on this paper. DecisionTree is used in this paper and we get very similar result. SVC is mentioned in some papers such as this one.
Since current discretization is naive, it seems hard to expect big improvement.
Any other comments?
cc @jnothman. Feel free to close it if there is better example.
Current result from Circle CI.