[WIP] Correct kernel docstrings to explain evaluation of gradient#8412
Closed
dalmia wants to merge 1 commit intoscikit-learn:masterfrom
Closed
[WIP] Correct kernel docstrings to explain evaluation of gradient#8412dalmia wants to merge 1 commit intoscikit-learn:masterfrom
dalmia wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8412 +/- ##
==========================================
- Coverage 96.19% 94.75% -1.45%
==========================================
Files 348 342 -6
Lines 64645 60816 -3829
==========================================
- Hits 62187 57624 -4563
- Misses 2458 3192 +734
Continue to review full report at Codecov.
|
jnothman
reviewed
Feb 6, 2018
Member
jnothman
left a comment
There was a problem hiding this comment.
I think this is too much information in the Parameters sections. We should be making this change in the Returns sections only
Contributor
|
Closed in #18115 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8393
What does this implement/fix? Explain your changes.
This corrects the docstrings of the
GaussianProcesskernels to indicate that wheneval_gradientisTrue, the matrix returned is the gradient of the log-transformed hyperparameters of the kernel and not that of the hyperparameters. Also, I've added comments in sections of the code indicating how the gradient has been calculated.