[MRG] Spectral_embedding mistake correction#8217
Closed
devanshdalal wants to merge 2 commits intoscikit-learn:masterfrom
devanshdalal:devanshdalal/bug-fix-#8189
Closed
[MRG] Spectral_embedding mistake correction#8217devanshdalal wants to merge 2 commits intoscikit-learn:masterfrom devanshdalal:devanshdalal/bug-fix-#8189
devanshdalal wants to merge 2 commits intoscikit-learn:masterfrom
devanshdalal:devanshdalal/bug-fix-#8189
Conversation
Member
|
Please use a more descriptive PR title |
agramfort
reviewed
Jun 6, 2017
| tol=eigen_tol, v0=v0) | ||
| embedding = diffusion_map.T[n_components::-1] * dd | ||
| embedding = diffusion_map.T[n_components::-1] | ||
| if(norm_laplacian): |
agramfort
reviewed
Jun 6, 2017
| largest=False) | ||
| embedding = diffusion_map.T * dd | ||
| embedding = diffusion_map.T | ||
| if(norm_laplacian): |
agramfort
reviewed
Jun 6, 2017
| lambdas, diffusion_map = eigh(laplacian) | ||
| embedding = diffusion_map.T[:n_components] * dd | ||
| embedding = diffusion_map.T | ||
| if(norm_laplacian): |
agramfort
reviewed
Jun 6, 2017
| lambdas, diffusion_map = lobpcg(laplacian, X, tol=1e-15, | ||
| largest=False, maxiter=2000) | ||
| embedding = diffusion_map.T[:n_components] * dd | ||
| embedding = diffusion_map.T |
Member
There was a problem hiding this comment.
why removing the :n_components?
Member
|
@devanshdalal any example is clearly impacts where we see that bug fix has a practical positive implication? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8129
Please provide suggestions for this pull request.
I hope more strong unit_tests might be needed,