[MRG] Replaced float with int in examples#8040
Merged
lesteve merged 5 commits intoscikit-learn:masterfrom Feb 3, 2017
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8017
What does this implement/fix? Explain your changes.
This replaces
floatwithintin the examples to remove theVisibleDeprecationWarningencountered due to the indices being of a non-integer type.Any other comments?
As mentioned in the issue thread, I wasn't able to replicate most of the warnings appearing on the build that was linked to. However, I encountered warnings in other examples that were not present in the build and hence, I chose to not modify them. Please give your suggestions in this regard.