[MRG] Fix Isomap to accept sparse matrix#7876
Closed
garretthoffman wants to merge 1 commit intoscikit-learn:masterfrom
Closed
[MRG] Fix Isomap to accept sparse matrix#7876garretthoffman wants to merge 1 commit intoscikit-learn:masterfrom
garretthoffman wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
jnothman
requested changes
Nov 15, 2016
| Xdense = X.A | ||
|
|
||
| for fmt in ("array", "csr", "csc", "coo", "lil"): | ||
| Xfmt = Xdense if fmt == "dense" else getattr(X, "to" + fmt)() |
Member
There was a problem hiding this comment.
You're now using fmt=='array' instead
| Xtrans = iso.fit_transform(Xfmt) | ||
| assert_equal(Xtrans.shape, (n_samples, 11)) | ||
| Xtrans = iso.transform(Xfmt) | ||
| assert_equal(Xtrans.shape, (n_samples, 11)) |
Member
There was a problem hiding this comment.
Can we check that the result is equivalent across all input formats, and between fit_transform and fit(X).transform(X)?
Member
|
Do you want to do the minor fixes? |
Member
|
Fixed in #10482 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7426
Update transform and _fit_transform methods to accept car_matrix and add test for sparse matrix formats.