[WIP] Common test for equivalence between sparse and dense matrices.#7590
Closed
maniteja123 wants to merge 2 commits intoscikit-learn:masterfrom
Closed
[WIP] Common test for equivalence between sparse and dense matrices.#7590maniteja123 wants to merge 2 commits intoscikit-learn:masterfrom
maniteja123 wants to merge 2 commits intoscikit-learn:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1572
What does this implement/fix? Explain your changes.
The common test is to ensure results on sparse and dense matrices are identical
Any other comments?
Some failing tests in estimators of
linear_modelall of which have separate code paths for sparse and dense matrices. I am not aware of any difference with its working on sparse and dense matrices. Please do let me know if there is any reason for this. I too will try to look into the code path. Thanks.Notes
In
neighborsmodule, the algorithm is set tobrutefor sparse matrices, but it isautoby default. So, I have set the paramalgorithmtobruteso that the tests pass.