[MRG+2] ENH/MNT results_ --> cv_results; test_mean_score --> mean_test_score et al. by raghavrv · Pull Request #7324 · scikit-learn/scikit-learn

raghavrv · 2016-09-01T07:22:53Z

Addresses #7205

jnothman · 2016-09-02T05:42:12Z

doc/whats_new.rst

    :class:`model_selection.RandomizedSearchCV` utilities.

-  - **The enhanced `results_` attribute**
+  - **The enhanced `cv_results_` attribute**


SHould use double-backticks

jnothman · 2016-09-02T05:44:42Z

What about examples? You should be able to get no results from git grep -w results_ I'd think...

raghavrv · 2016-09-02T08:08:45Z

What about examples?

Oops! Good catch! I think that's why circle is failing...

yenchenlin · 2016-09-03T13:19:57Z

sklearn/model_selection/_search.py

+                self.cv_results_['params'],
+                self.cv_results_['mean_test_score'],
+                self.cv_results_['std_test_score'])):
+            scores = np.array(list(self.cv_results_['split%d_test_score' %


maybe move % to the next line?

raghavrv · 2016-09-06T08:00:09Z

@jnothman @amueller bump

jnothman · 2016-09-06T11:56:05Z

You didn't actually run that git grep, did you?

jnothman · 2016-09-06T12:00:46Z

Once you've got those last two, the file list covers #6697.

jnothman · 2016-09-06T12:03:31Z

sklearn/model_selection/_search.py

-            'test_mean_score'   : [0.81, 0.60, 0.75, 0.82],
-            'test_std_score'    : [0.02, 0.01, 0.03, 0.03],
-            'test_rank_score'   : [2, 4, 3, 1],
+            'split0_test_score' : [0.8, 0.7, 0.8, 0.9],


Confirming with @amueller: these names work better for you?

yeah I think that's better

jnothman · 2016-09-06T12:04:56Z

And after those tutorial examples, this LGTM.

jnothman · 2016-09-06T12:11:21Z

why cosmit?

raghavrv · 2016-09-06T12:29:49Z

Thanks for the review and +1 :)

raghavrv · 2016-09-06T12:31:21Z

You didn't actually run that git grep, did you?

😛

raghavrv · 2016-09-06T12:43:36Z

examples/model_selection/grid_search_digits.py

-    for i in range(len(clf.results_['params'])):
+    means = clf.cv_results_['mean_test_score']
+    stds = clf.cv_results_['std_test_score']
+    for mean, std, params in zip(means, stds, clf.cv_results_['params']):


I used this chance to address an old review ;)

amueller · 2016-09-06T16:20:33Z

Why did travis not run on this? other than that: LGTM. And changing the book again lol

raghavrv · 2016-09-06T16:38:56Z

haha

raghavrv · 2016-09-06T16:39:14Z

I'll try a rebase-force-push and see if that restarts travis...

NelleV · 2016-09-07T16:27:18Z

Thanks!

raghavrv · 2016-09-07T19:53:13Z

Thanks for the reviews and merge!

jnothman · 2016-09-07T22:12:26Z

Thank you for doing all the messy work!

On 8 September 2016 at 05:53, Raghav RV notifications@github.com wrote:

Thanks for the reviews and merge!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7324 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz68QF25kjw3mQ9CMxhGRNiMZZxOBQks5qnxYqgaJpZM4JyY_H
.

raghavrv mentioned this pull request Sep 1, 2016

[MRG+2] Timing and training score in GridSearchCV #7325

Merged

4 tasks

jnothman reviewed Sep 2, 2016
View reviewed changes

yenchenlin reviewed Sep 3, 2016
View reviewed changes

raghavrv force-pushed the rename_results_ branch from 017a5e0 to e941f61 Compare September 6, 2016 08:00

jnothman reviewed Sep 6, 2016
View reviewed changes

jnothman changed the title ~~[MRG] COSMIT results_ --> cv_results; test_mean_score --> mean_test_score et al.~~ [MRG+1] COSMIT results_ --> cv_results; test_mean_score --> mean_test_score et al. Sep 6, 2016

raghavrv changed the title ~~[MRG+1] COSMIT results_ --> cv_results; test_mean_score --> mean_test_score et al.~~ [MRG+1] ENH/MNT results_ --> cv_results; test_mean_score --> mean_test_score et al. Sep 6, 2016

raghavrv reviewed Sep 6, 2016
View reviewed changes

amueller changed the title ~~[MRG+1] ENH/MNT results_ --> cv_results; test_mean_score --> mean_test_score et al.~~ [MRG+2] ENH/MNT results_ --> cv_results; test_mean_score --> mean_test_score et al. Sep 6, 2016

raghavrv force-pushed the rename_results_ branch from 9a43353 to ca94d05 Compare September 6, 2016 16:45

results_ --> cv_results_; "test_mean_score" --> "mean_test_score" et al.

4dbab26

raghavrv force-pushed the rename_results_ branch from ca94d05 to 4dbab26 Compare September 6, 2016 16:46

NelleV merged commit 35bb1c6 into scikit-learn:master Sep 7, 2016

raghavrv deleted the rename_results_ branch September 7, 2016 19:53

Uh oh!

Conversation

raghavrv commented Sep 1, 2016

Uh oh!

jnothman Sep 2, 2016

Choose a reason for hiding this comment

Uh oh!

jnothman commented Sep 2, 2016

Uh oh!

raghavrv commented Sep 2, 2016

Uh oh!

yenchenlin Sep 3, 2016

Choose a reason for hiding this comment

Uh oh!

raghavrv Sep 3, 2016

Choose a reason for hiding this comment

Uh oh!

raghavrv commented Sep 6, 2016

Uh oh!

jnothman commented Sep 6, 2016

Uh oh!

jnothman commented Sep 6, 2016

Uh oh!

jnothman Sep 6, 2016

Choose a reason for hiding this comment

Uh oh!

amueller Sep 6, 2016

Choose a reason for hiding this comment

Uh oh!

jnothman commented Sep 6, 2016

Uh oh!

jnothman commented Sep 6, 2016

Uh oh!

raghavrv commented Sep 6, 2016

Uh oh!

raghavrv commented Sep 6, 2016

Uh oh!

raghavrv Sep 6, 2016

Choose a reason for hiding this comment

Uh oh!

amueller commented Sep 6, 2016

Uh oh!

raghavrv commented Sep 6, 2016

Uh oh!

raghavrv commented Sep 6, 2016

Uh oh!

NelleV commented Sep 7, 2016

Uh oh!

raghavrv commented Sep 7, 2016

Uh oh!

jnothman commented Sep 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants