[WIP] MNT Remove implicit 'binary' averaging with pos_labels#7134
Closed
raghavrv wants to merge 1 commit intoscikit-learn:masterfrom
Closed
[WIP] MNT Remove implicit 'binary' averaging with pos_labels#7134raghavrv wants to merge 1 commit intoscikit-learn:masterfrom
raghavrv wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
MNT Make sure err is raised when 'binary' averaging is not explicit TST Move fscores/prec/recall into undefined_multiclass case etc...
Member
|
Thanks. |
Member
|
Just for my information, did you make any of the review response changes here yet? |
Member
Author
|
No I haven't yet... |
Member
|
Do you want me to take this one over, @raghavrv? |
Member
Author
|
@jnothman Please go ahead. I'll not let this stand in way of 0.18... |
Member
|
Closing in favour of #7304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5434
(Separated from #5528 )