Closed
Conversation
…to categorical variables. Replaced the threshold attribute of SplitRecord and Node with SplitValue.
…hat defaults to -1 for each feature (indicating non-categorical feature).
…(). Enforced max n_categories=2**31 for RandomSplitter.
…rating a big list of random numbers for every sample in every node when sending it left or right.
…hat there are no sparse categorical variables, since they're currently not supported.
…ith more than 64 categories.
… to make sure we free the bit cache.
…splits until a non-trivial one is found
…rectly with ensembles. Refactored the categorical transformations into functions.
…identally creates a trivial split.
…resented in the local sample.
…gorical features.
…iate for categorical features.
…n with numpy v1.6. This should be reverted when support for numpy v1.6 is dropped.
…ees, forests, and gradient boosting. Tweaked unit tests to match.
Contributor
|
fyi, you can create an appveyor account for yourself, add your fork to it, and then run tests on branches on that fork and view results with your own appveyor account. this has the added benefit of also not having to wait for the queued builds from other PRs to finish before seeing your results. |
Contributor
Author
|
Thanks. Looks like free accounts are limited to 14 days though. That's probably not going to work for me, given the limited fraction of my time I can devote to this project. |
Contributor
|
it's actually free for open source projects (i.e. non-private repos on github) |
Contributor
Author
|
Ok I was able to set up my own account. Sorry for the line noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating this PR to track down Appveyor failures in #4899.
Will close once they are figured out.