[WIP] Add Absolute Mean Percentage Error as available loss function in SGDR…#6605
[WIP] Add Absolute Mean Percentage Error as available loss function in SGDR…#6605maciejjaskowski wants to merge 1 commit intoscikit-learn:mainfrom
Conversation
|
Thanks for the PR and sorry for the slow reply. Also, this needs to be added to the docstrings explaining the possible losses and needs a test that it's actually minimizing mape. |
|
I think it's a good idea to adding MAPE as a loss function. |
|
You could load this branch into your working copy, merge it with the current master, install it and use... It would not take a great deal of effort to get this PR to a state where it could be merged, but we won't merge it without appropriate documentation and tests. And as @amueller says, it would be good to have MAPE as an evaluation metric for symmetry. |
|
Also needs some docs, at least mention in the docstring. Also in whatsnew. Not sure how easy it is to test this as part of SGDClassifier. Maybe hand-designed example? |
|
Numerically, I see issues with |
|
@thomasjpfan this pull request was superseded by #10711, itself closed in favor of #15007. Can we close it? |
I am pretty sure I saw someone on scikit-learn github considering adding MAPE as loss function and I wanted to have it anyway, so there it is (although I can't google it back)
If that is useful, I should probably add some tests and/or documentation. Let me know!