[MRG+2] Fix learning_rate default value in update_terminal_regions()#6463
[MRG+2] Fix learning_rate default value in update_terminal_regions()#6463movelikeriver wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
|
is this fixing a known issue? can we have a test? How did you spot the pb? |
|
it's claimed as default value of 0.1 in comment, and also in caller function, so the default value of 0.1 is the expected behavior. |
|
I think this is good and a typo fix. @pprett? |
|
So the alternative is to update the documentation to match the value, and hence not affect user code. If we update the value to match the documentation, we should at least note this clearly in What's New, as it's a breach of backwards compatibility. |
|
I don't thing this will affect any user code, unless then "manually" called |
|
This would atleast need a whatsnew entry... Otherwise LGTM... |
|
Yes, please add a bug fix entry to whats_new.rst, then we can merge. |
|
@glemaitre could you have a look at this? Apart for the missing what's new entry I think it might be good to merge with a +2. |
Fix learning_rate default value in update_terminal_regions() in gradient_boosting.py