[MRG] insert versionadded versionchanged directives in docstrings for 0.18#5856
[MRG] insert versionadded versionchanged directives in docstrings for 0.18#5856welch wants to merge 2 commits intoscikit-learn:masterfrom welch:issue-5505-doc-versionadded-0.18
Conversation
sklearn/_build_utils/cythonize.py
Outdated
There was a problem hiding this comment.
I don't think this is ever rendered / interpreted. It doesn't hurt either, though.
|
thank you, this is very helpful. The main comment is that for new files, each public class or function in the file needs a versionadded (or versionchanged if it was moved, as the ones in the model_selection module) |
|
comments addressed:
I wouldn't ordinarily squash mid-review, but it's tidier reading. |
sklearn/exceptions.py
Outdated
There was a problem hiding this comment.
All the exceptions where actually all moved, but from different places...
|
Thanks for all the changes. This looks good. It might be nice to say where the exceptions came from, but I don't feel strongly about it. |
|
chased down the original exception class locations and noted in versionadded directives |
|
merged via #7403 |
issue #5505 versionadded/versionchanged directives for new stuff in 0.18.
It was not clear to me if I should also add these at the file/module level for new files (I did).