[MRG] add fast replacement for np.cov#5344
Closed
larsmans wants to merge 1 commit intoscikit-learn:masterfrom
Closed
[MRG] add fast replacement for np.cov#5344larsmans wants to merge 1 commit intoscikit-learn:masterfrom
larsmans wants to merge 1 commit intoscikit-learn:masterfrom
Conversation
Timings with NumPy 1.8.2 and ATLAS:
>>> X = np.random.rand(13000,60)
>>> %timeit np.cov(X)
1 loops, best of 3: 2.82 s per loop
>>> %timeit fast_cov(X)
1 loops, best of 3: 1.71 s per loop
Memory use is also halved compared to NumPy <= 1.10, at least for
n_samples >> n_features. NumPy 1.11 will have a more memory-efficient
cov implementation.
Member
|
tests are failing... otherwise looks like a good idea. |
16 tasks
Contributor
There was a problem hiding this comment.
Dont want to be picky, but shouldnt bias and rowvar be documented?
Member
Since numpy 1.11 is now the minimal requirement this PR becomes unnecessary. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is inspired by some recent PRs over at NumPy concerning
np.covperformance.Timings with NumPy 1.8.2 and ATLAS:
Memory use is also halved compared to NumPy <= 1.10, at least for
n_samples≫n_features. NumPy 1.11 will have a more memory-efficientcovimplementation.