Closed
Conversation
and assert_not_raises
* Check if no error is raised when fit is called with a different number of features * Check if estimator is reset when fit is called after a partial_fit * Check if error is raised when no of features changes between different partial_fit calls * Check if partial_fit does not overwrite the previous model * Check if classes argument is parsed and validated correctly * Check if clone(estimator).partial_fit == estimator.partial_fit * Check if partial_fit returns self
Member
Author
|
Running it on the same dataset yields "only"
Testing on C-ordered data gives "only" three failures, |
6 tasks
c359d02 to
15169c2
Compare
Member
Author
|
Naturally doesn't find #4507 because that would have been too easy. |
Member
Author
|
(doesn't find #4507 because it requires |
Contributor
|
By the way, this makes me think we are testing different array layouts for trees in https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/tree/tests/test_tree.py#L741 It may be nice to generalize this test as a common test :) |
Member
Author
|
Adding the strided test would definitely be nice. This PR is not in a great shape as it basically exposes issues with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to add a common test for #4507 , uses #3907.
Either I'm doing something wrong (I hope so) or this is not looking good.Found my issue.