[WIP] Earth (MARS), continuation#4341
Closed
mehdidc wants to merge 31 commits intoscikit-learn:masterfrom
Closed
Conversation
…ing" This reverts commit 87db631.
Getting recent changes from scikit-learn people.
I thought they were working before. Maybe I ran the wrong tests or something.
…klearn and to work with gen_rst
1. Added allow_linear argument 2. Fixed a bug in the way endspan argument was processed 3. Fixed a bug in the way sample_weights were being applied 4. Added simple test case for 3 (test needs to be improved, may be platform dependent) 5. Fixed a typo where min_search_points was accidentally min_searh_points
Member
There was a problem hiding this comment.
make sure lines are less than 80c everywhere even in the docstring / doc
Member
|
have a look at travis failure |
This was referenced Mar 9, 2015
Closed
Member
|
Closing given that PyEarth is in sklearn-contrib; that this PR hasn't been updated in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation Of #2285 here.