[MRG] GBM & meta-ensembles - support for class_weight#4215
Closed
trevorstephens wants to merge 1 commit intoscikit-learn:mainfrom
Closed
[MRG] GBM & meta-ensembles - support for class_weight#4215trevorstephens wants to merge 1 commit intoscikit-learn:mainfrom
trevorstephens wants to merge 1 commit intoscikit-learn:mainfrom
Conversation
Contributor
Author
|
Know everyone's busy, but anyone had a chance to look over this at all? Would it be easier for review if I broke it into a separate PR per classifier? |
Member
|
I think the scope is fine. Sorry, there is just a lot going on. |
Contributor
Author
|
No worries |
Contributor
Author
|
Thanks for the review @vmichel ! I'll try to address your concerns over the weekend + rebase. |
Contributor
Author
|
Is this feature still on the roadmap? It would be useful. |
Member
|
Would be nice to have a fresh start here maybe. @ogrisel and @lorentzenchr might be interested. Closing for now, unless it reactivates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring #4114 on top of #4190 and removing the GBM coding style changes from the scope of this PR for ease of review. Basically I'm adding
class_weightsto the remaining ensemble classes as was done in #3961 for forests and trees.@amueller @pprett @glouppe you have all at least glanced at #4114 so perhaps you'll have a chance to review the new refactored version here.