[MRG+1] Nearest neighbor radius query should include points in the boundary.#3919
Closed
tvarvadoukas wants to merge 3 commits intoscikit-learn:masterfrom
Closed
[MRG+1] Nearest neighbor radius query should include points in the boundary.#3919tvarvadoukas wants to merge 3 commits intoscikit-learn:masterfrom
tvarvadoukas wants to merge 3 commits intoscikit-learn:masterfrom
Conversation
added 2 commits
November 30, 2014 13:45
…he boundary of a radius search in the 'brute' method.
… algorithms. They should all return the same result and include the points in the boundaries.
Member
There was a problem hiding this comment.
Can you please install pep8, run it on the files impacted by this PR and fix the warnings related only to your change.
Member
|
LGTM, thanks @tvarvadoukas! |
3 tasks
Member
|
@jnothman this is related to your PR on refactoring neighbor estimators (although should be mergeable independently). |
Member
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that although
kd_treeandball_treealgorithms return points in the boundaries, thebrutemethod does not. Included a fix forbruteand added a toy testcase to check the consistency between the algorithms for this edgecase.