[Callbacks] FIX Make set_callbacks accept only instances#33574
Merged
jeremiedbb merged 5 commits intoscikit-learn:callbacksfrom Mar 19, 2026
Merged
[Callbacks] FIX Make set_callbacks accept only instances#33574jeremiedbb merged 5 commits intoscikit-learn:callbacksfrom
jeremiedbb merged 5 commits intoscikit-learn:callbacksfrom
Conversation
jeremiedbb
reviewed
Mar 18, 2026
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb
reviewed
Mar 18, 2026
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #27676
What does this implement/fix? Explain your changes.
CallbackSupportMixin.set_callbacksverify that the provided callbacks are valid by usingisinstancewith the callback protocol. Butisinstancewith protocols also accepts classes, so passing the class of a valid callback would pass the test inset_callbacksand create problems later.The change simply adds a
inspect.isclasstest to reject classes and only accept instances.AI usage disclosure
I used AI assistance for:
Any other comments?
ping @jeremiedbb @ogrisel @StefanieSenger @lesteve