[Callbacks] API Rename eval_on_fit_task_*#33561
Merged
jeremiedbb merged 4 commits intoscikit-learn:callbacksfrom Mar 17, 2026
Merged
[Callbacks] API Rename eval_on_fit_task_*#33561jeremiedbb merged 4 commits intoscikit-learn:callbacksfrom
jeremiedbb merged 4 commits intoscikit-learn:callbacksfrom
Conversation
Member
|
+1 for +0.5 for -1 for |
Member
|
Small preference for |
Member
|
I'm +1 on on |
Contributor
|
I'm +1 for |
Member
Author
|
I'm 1 for call, +0.75 for invoke, +0.5 for run and -1 for the other 2 |
Member
Author
|
🥁 |
Member
Author
|
call: +4.5 Let's go for call then :) (I interpreted loic's answer as +1 call, +0.5 invoke, -1 rest) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in scikit-learn/enhancement_proposals#90 (comment),
evalmight evoke model evaluation since we're a ML library.2 alternative names were proposed in different discussion channels:
run_on_fit_task_*andcall_on_fit_task_*.I also asked an ai to propose other alternatives. Here's its answer:
I don't like
dispatchandnotify.I wasn't aware that
invokewas common callback vocabulary. I think that we can assume that developers of estimator will be either, socallis probably a better call for us. Hence I went forcall.Let me know what's your preference.
ping @ogrisel @FrancoisPgm @StefanieSenger @lesteve