[Callbacks] Rename with_fit_callbacks -> with_callbacks#33547
Merged
jeremiedbb merged 3 commits intoscikit-learn:callbacksfrom Mar 16, 2026
Merged
[Callbacks] Rename with_fit_callbacks -> with_callbacks#33547jeremiedbb merged 3 commits intoscikit-learn:callbacksfrom
jeremiedbb merged 3 commits intoscikit-learn:callbacksfrom
Conversation
StefanieSenger
approved these changes
Mar 16, 2026
Member
There was a problem hiding this comment.
Yes, thank you @jeremiedbb! (Can be merged after the conflict is resolved.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in scikit-learn/enhancement_proposals#90 (comment) in the SLEP, the current name,
with_fit_callbacks, is too specific since we'll likely want to reuse this decorator for other methods when we extend the callback API.So let's directly go with a generic
with_callbacks.Since, as a decorator, it receives the decorated method as first arg, it will be easy to use it for methods other than fit in the future, specializing the behavior for the different methods if needed.
(note that the
callback_management_contextcontext manager used inside the decorator is currently dedicated to fit, but that's fine because this one is private, so we'll be able to modify it later as needed without touching the public api)ping @ogrisel @FrancoisPgm @StefanieSenger @lesteve