Skip to content

FIX Remove unsused arg in callback_management_context#33385

Merged
jeremiedbb merged 1 commit intoscikit-learn:callbacksfrom
FrancoisPgm:rm_arg_callback_manager
Feb 23, 2026
Merged

FIX Remove unsused arg in callback_management_context#33385
jeremiedbb merged 1 commit intoscikit-learn:callbacksfrom
FrancoisPgm:rm_arg_callback_manager

Conversation

@FrancoisPgm
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Towards #27676

What does this implement/fix? Explain your changes.

Remove the fit_method_name argument of the callback_management_context context manager since it not used anymore, as the callback context is no more initialized in the context manager.

AI usage disclosure

I used AI assistance for:

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Any other comments?

ping @jeremiedbb

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jeremiedbb jeremiedbb merged commit 16dc753 into scikit-learn:callbacks Feb 23, 2026
35 of 37 checks passed
@FrancoisPgm FrancoisPgm deleted the rm_arg_callback_manager branch February 24, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants