Skip to content

MAINT use the rapidsai channel first in the CUDA CI config#33212

Merged
lesteve merged 2 commits intoscikit-learn:mainfrom
ogrisel:cuda-ci-lock-file
Feb 5, 2026
Merged

MAINT use the rapidsai channel first in the CUDA CI config#33212
lesteve merged 2 commits intoscikit-learn:mainfrom
ogrisel:cuda-ci-lock-file

Conversation

@ogrisel
Copy link
Copy Markdown
Member

@ogrisel ogrisel commented Feb 5, 2026

Apparently this is needed to get deterministically non-failing mamba dependency resolution on various hosts we tried during the array API meeting.

@ogrisel ogrisel added the CUDA CI label Feb 5, 2026
@github-actions github-actions bot removed the CUDA CI label Feb 5, 2026
Copy link
Copy Markdown
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lesteve lesteve enabled auto-merge (squash) February 5, 2026 14:54
@lesteve
Copy link
Copy Markdown
Member

lesteve commented Feb 5, 2026

Weird error unrelated to the lock-file update on macOS arm build log. I restarted the CI to see if it disappears ...

__________ test_estimator_get_response_values[False-estimator2-score] __________
[gw1] darwin -- Python 3.13.11 /Users/runner/miniconda3/envs/testvenv/bin/python

estimator = KMeans(n_clusters=2, n_init=1), response_method = 'score'
return_response_method_used = False

    @pytest.mark.parametrize(
        "estimator, response_method",
        [
            (LinearRegression(), "predict"),
            (KMeans(n_clusters=2, n_init=1), "predict"),
            (KMeans(n_clusters=2, n_init=1), "score"),
            (KMeans(n_clusters=2, n_init=1), ["predict", "score"]),
            (IsolationForest(random_state=0), "predict"),
            (IsolationForest(random_state=0), "decision_function"),
            (IsolationForest(random_state=0), ["decision_function", "predict"]),
        ],
    )
    @pytest.mark.parametrize("return_response_method_used", [True, False])
    def test_estimator_get_response_values(
        estimator, response_method, return_response_method_used
    ):
        """Check the behaviour of `_get_response_values`."""
        X, y = np.random.RandomState(0).randn(10, 2), np.array([0, 1] * 5)
        estimator.fit(X, y)
        results = _get_response_values(
            estimator,
            X,
            response_method=response_method,
            return_response_method_used=return_response_method_used,
        )
        chosen_response_method = (
            response_method[0] if isinstance(response_method, list) else response_method
        )
        prediction_method = getattr(estimator, chosen_response_method)
>       assert_array_equal(results[0], prediction_method(X))
E       AssertionError: 
E       Arrays are not equal
E       
E       Mismatched elements: 1 / 1 (100%)
E       Max absolute difference among violations: 8.8817842e-16
E       Max relative difference among violations: 1.36774746e-16
E        ACTUAL: array(-6.493731)
E        DESIRED: array(-6.493731)

X          = array([[ 1.76405235,  0.40015721],
       [ 0.97873798,  2.2408932 ],
       [ 1.86755799, -0.97727788],
       [ 0.95... 0.12167502],
       [ 0.44386323,  0.33367433],
       [ 1.49407907, -0.20515826],
       [ 0.3130677 , -0.85409574]])
chosen_response_method = 'score'
estimator  = KMeans(n_clusters=2, n_init=1)
prediction_method = <bound method _BaseKMeans.score of KMeans(n_clusters=2, n_init=1)>
response_method = 'score'
results    = (-6.493731071053089, None)
return_response_method_used = False
y          = array([0, 1, 0, 1, 0, 1, 0, 1, 0, 1])

../sklearn/utils/tests/test_response.py:81: AssertionError

@lesteve lesteve merged commit 27a3b6d into scikit-learn:main Feb 5, 2026
56 of 57 checks passed
@github-project-automation github-project-automation bot moved this to Done in Array API Feb 5, 2026
@ogrisel ogrisel deleted the cuda-ci-lock-file branch February 5, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants