✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: f47ace0. Link to the linter CI: here}

@OmarManzoor I've just realised the string y_true tests are to check for mixed array inputs.

I am wondering whether we separate testing of:

• support for mixed array input, and
• support for array API - i.e. result is the same when using numpy vs xp

I've actually have a PR to add a common test to check for mixed array input support: #32755. It means that:

• we can check for the specific array conversion combinations we wish to
  • it also allows us to check for non-numpy to numpy conversion, which this particular set up does not
• avoids us amending current common metric tests to add mixed array input tests
  • the separation also makes it also easier to test, as not all metrics will support mixed input during the process of adding support

cc @ogrisel for your thoughts too.

@OmarManzoor I've just realised the string y_true tests are to check for mixed array inputs.

I am wondering whether we separate testing of:

• support for mixed array input, and
• support for array API - i.e. result is the same when using numpy vs xp

I've actually have a PR to add a common test to check for mixed array input support: #32755. It means that:

• we can check for the specific array conversion combinations we wish to

  • it also allows us to check for non-numpy to numpy conversion, which this particular set up does not

• avoids us amending current common metric tests to add mixed array input tests

Yes that should be good I think. The reason the tests for y_true being strings were added in the same test was because we wanted to support that for these metrics. I think you can separate them out now considering the other PR related to mixed types.

Thanks @OmarManzoor ! I think I need to push #32755 first, before this can go in.