Skip to content

[MRG] DOC: add Visualization API ROC example link to model_evaluation#31591

Closed
EvMossan wants to merge 2 commits intoscikit-learn:mainfrom
EvMossan:doc/plot_roc_curve_visualization_api-link
Closed

[MRG] DOC: add Visualization API ROC example link to model_evaluation#31591
EvMossan wants to merge 2 commits intoscikit-learn:mainfrom
EvMossan:doc/plot_roc_curve_visualization_api-link

Conversation

@EvMossan
Copy link
Copy Markdown

Reference Issues/PRs

Towards #30621

What does this implement/fix?

Adds a link to the end-to-end example plot_roc_curve_visualization_api.py
in the ROC section of the User Guide.

Any other comments?

None.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 19, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: ec53ba7. Link to the linter CI: here

@EvMossan EvMossan changed the title DOC: add Visualization API ROC example link to model_evaluation [MRG] DOC: add Visualization API ROC example link to model_evaluation Jun 22, 2025
@StefanieSenger StefanieSenger added good first PR to review Simple atomic PR to review and removed good first PR to review Simple atomic PR to review labels Jun 25, 2025
@StefanieSenger
Copy link
Copy Markdown
Member

Hi @evgmosme, thanks for your PR.

I need to admit that I am really unsure if we want to add any more link to this very basic example or if it is better to entirely remove it. We use the from_estimator syntax in many other examples and link them in proper places.

Let's wait for other opinions.

@StefanieSenger StefanieSenger added the Waiting for Second Reviewer First reviewer is done, need a second one! label Jun 29, 2025
@ArturoAmorQ
Copy link
Copy Markdown
Member

I agree that this example is already linked in the Visualizations and the Developing with the Plotting API where it makes the most sense.

But I'm also +1 to entirely removing this example.

@ArturoAmorQ
Copy link
Copy Markdown
Member

I'm then closing this PR, but I'm sure you can find some other places where you can contribute @EvMossan :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Waiting for Second Reviewer First reviewer is done, need a second one!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants