DOC add links to plot_polynomial_interpolation.py#31576
Closed
chloetychang wants to merge 9 commits intoscikit-learn:mainfrom
chloetychang:main
Closed
DOC add links to plot_polynomial_interpolation.py#31576chloetychang wants to merge 9 commits intoscikit-learn:mainfrom chloetychang:main
chloetychang wants to merge 9 commits intoscikit-learn:mainfrom
chloetychang:main
Conversation
virchan
reviewed
Jul 1, 2025
Member
virchan
left a comment
There was a problem hiding this comment.
Thank you for the PR, @chloetychang! I have a few comments.
virchan
approved these changes
Jul 9, 2025
Member
virchan
left a comment
There was a problem hiding this comment.
LGTM! Thanks, @chloetychang!
@adrinjalali, would you like to have a look and merge this? The example link is already in the docstrings of PolynomialFeatures and SplineTransformer, so I think the user guide is the only place to add.
Member
|
This example is actually linked via an image from this user guide as well. So I think we can close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #30621
What does this implement/fix? Explain your changes.
This adds a direct link to the example
plot_polynomial_interpolation.py, making it more discoverable. While the example is already linked via an image earlier in the documentation, it may not be intuitive for users to access it that way.