Add example link to RandomForestClassifier docstring#31569
Add example link to RandomForestClassifier docstring#31569Saanvi-2711 wants to merge 4 commits intoscikit-learn:mainfrom Saanvi-2711:doc
Conversation
|
Hi! This PR fixes #30766 by adding a missing example reference to the |
StefanieSenger
left a comment
There was a problem hiding this comment.
Hi @Saanvi-2711,
Thanks for your PR!
At first: could you please change the "Closes #...." in your issue description into something else? "Closes" is in fact a github command that will close the issue, you can cange it into "Towards #...."
Then, the example is is simply added to the See Also section without describing its context. We have discouraged you to do so in the issue description. Would you mind going back and check other PRs on what we actually need for a good reference?
Thank you!
StefanieSenger
left a comment
There was a problem hiding this comment.
Oh, I have just seen that we had decided that no references need to be added in another PR already. You could have seen this in the ToDo list of the issue.
I will therefore close this PR. Hope to see you on another task.
|
Thank you for the detailed feedback and for taking the time to review my PR. I now understand why the reference addition wasn’t needed and that I missed the latest updates in the ToDo list and other PRs. I’ll make sure to check those thoroughly next time before submitting a PR. I’d love to continue contributing to scikit-learn and will look for another suitable issue to work on. Thanks again for the opportunity! |
Reference Issues/PRs
Towards #30621
What does this implement/fix? Explain your changes.
This PR adds a link to the forest importances example in the
RandomForestClassifierdocstring, under the "See Also" section.Any other comments?
N/A