Skip to content

DOC add link to plot_multi_metric_evaluation in make scorer #30841#31561

Closed
romanwixinger wants to merge 1 commit intoscikit-learn:mainfrom
romanwixinger:feature/link_to_sample_scorer
Closed

DOC add link to plot_multi_metric_evaluation in make scorer #30841#31561
romanwixinger wants to merge 1 commit intoscikit-learn:mainfrom
romanwixinger:feature/link_to_sample_scorer

Conversation

@romanwixinger
Copy link
Copy Markdown

Towards #30621 #30621.

This PR adds a reference to the 'plot_multi_metric_evaluation.py' example.

The 'plot_multi_metric_evaluation' example is already referenced in the User Guide. I added a link to the API docs of the related make_scorer function, because users might start from there.

However, this example , namely :ref:sphx_glr_auto_examples_linear_model_plot_quantile_regression.py, from the API documentation would also be a valid example as more parameters are used.

…the documentation of the make_scorer function.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 16, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 878fb71. Link to the linter CI: here

Copy link
Copy Markdown
Member

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. that looks pretty good. Thank you @romanwixinger!

@adrinjalali, would you like to have a look?

... scoring=ftwo_scorer)

For an example on how to use multiple scorers at the same time see
:ref:`sphx_glr_auto_examples_model_selection_plot_multi_metric_evaluation.py`.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So multi metric scoring is interesting, as in, the class itself is not public, and make_scorer could potentially support it, but it doesn't (ref #31540)

The example doesn't really show how to do multi metric scoring with make_scorer, so the location of this link doesn't seem right to me.

We do have a link to the example in the user guide, but I think there can also be a link in the API docs of gridsearch classes to show how users can do multi metric scoring, instead of here.

@lucyleeow
Copy link
Copy Markdown
Member

I am going to close this due to inactivity and because we decided to close #26927

@lucyleeow lucyleeow closed this Sep 8, 2025
@lucyleeow
Copy link
Copy Markdown
Member

Re-opening, as this was reviewed and someone else may wish to continue

@lucyleeow lucyleeow reopened this Sep 8, 2025
@adrinjalali
Copy link
Copy Markdown
Member

Closing since no response from the OP.

@adrinjalali adrinjalali closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants