Skip to content

Doc add link self training#31514

Closed
Vedant-Kalbhor wants to merge 3 commits intoscikit-learn:mainfrom
Vedant-Kalbhor:doc-add-link-self_training
Closed

Doc add link self training#31514
Vedant-Kalbhor wants to merge 3 commits intoscikit-learn:mainfrom
Vedant-Kalbhor:doc-add-link-self_training

Conversation

@Vedant-Kalbhor
Copy link
Copy Markdown

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Towards #30621

This PR adds a hyperlink to the plot_semi_supervised_versus_svm_iris.py example in the SelfTrainingClassifier docstring, improving discoverability of semi-supervised learning examples.

Optionally, it also updates the User Guide section on semi-supervised learning to reference this tutorial.

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 10, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 66a6428. Link to the linter CI: here

Copy link
Copy Markdown
Member

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Vedant-Kalbhor,

thanks for your PR. It needs some more work:
a) on the linting (see comments)
b) on the location to put the link: Here we have the chance to put it in a specific spot where it is most useful for the users, because the example shows a specific thing.

What do you think of putting it into the param description for oob_score to show of to evaluate it's output with oob_score=True (while the default is False). Please also add a more specialised description pointing to what is shown on the example.

Thank you!

Comment on lines +1498 to +1499


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert this? It makes the linter fail.

Suggested change


.. versionadded:: 1.4


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Also this would make the linter fail.


.. versionadded:: 1.4

Examples
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add a new Examples section into a docstring. These are reserved for code snippets. I wrote this in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants