doc: add link to the plot_gmm_covariances example#31249
Merged
adrinjalali merged 3 commits intoscikit-learn:mainfrom May 6, 2025
Merged
doc: add link to the plot_gmm_covariances example#31249adrinjalali merged 3 commits intoscikit-learn:mainfrom
adrinjalali merged 3 commits intoscikit-learn:mainfrom
Conversation
StefanieSenger
approved these changes
Apr 28, 2025
Member
StefanieSenger
left a comment
There was a problem hiding this comment.
Thank you, @natmokval, that looks good to me. The location of the link in covariances_ docstring adds value for uses.
I would maybe move the link below the information on the shape (into line 637).
Member
|
@adrinjalali, do you think we can merge this? |
Contributor
Author
Thanks @StefanieSenger for reviewing this PR. I did as you suggested and moved the link below the information on the shape. |
Member
|
That looks very good, thanks again @natmokval. :) |
adrinjalali
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #30621.
This PR adds a reference to the 'plot_gmm_covariances.py' example.
The 'plot_gmm_covariances' example is already referenced in the User Guide. I added a link to make the example visible from the API documentation as well, but I'm not sure if that's necessary. I believe no additional references are needed, since it's already sufficiently covered in the User Guide.