DOC added link to example plot_svm_margin.py#30975
DOC added link to example plot_svm_margin.py#30975SwathiR1999 wants to merge 0 commit intoscikit-learn:mainfrom
Conversation
There was a problem hiding this comment.
Thanks for working on this, @SwathiR1999.
However, I see two problems here:
- Placing this example in the "1.4.5. Tips on Practical Use" section is not a good spot for this.
- The example doesn't seem to show what it claims: The effect on the
Cparam on the margin is not demonstrated.
As I would all in all consider this example to not add much value, I would suggest to re-purpose this PR to remove the example instead. Would you agree to that, @adrinjalali? Would you be willing to work on that, @SwathiR1999?
|
Thanks for the feedback, @StefanieSenger ! I understand the concerns. Would you prefer that I remove the example, or should I try improving it to better demonstrate the effect of C on the margin? |
|
Hi @SwathiR1999, good to know that you're ready for both options.
Let's wait for @adrinjalali's opinion on that. I cannot decide that. |
|
This is a very important message when it comes to SVMs actually. But I agree this example is far from ideal. Looking at the examples, I see |
|
Hi @adrinjalali , @StefanieSenger , Thanks for the feedback! I’ll work on merging Let me know how you'd like to proceed. Thanks! |
|
Doing it in this PR is fine, we can always rename the PR anyway. |
|
Hi @SwathiR1999, please ping me when you're finished for the moment and want a review. |
9705b75 to
54f6046
Compare
Reference Issues/PRs
References #30621
What does this implement/fix? Explain your changes.
This adds a reference to a visual example demonstrating the impact of the
Cparameter in SVM classification, making it easier for users to understand its effect on the decision boundary.