Added link to plot_grid_search_text_feature_extraction.py under TfidfVectorizer#30974
Conversation
There was a problem hiding this comment.
Thanks for your contribution, @AnthonyPrudent! It looks all good to me and I think it can be merged.
Apart from this PR, I am not so happy about the enumeration-like listing of links to examples in the TFIDF docstring, but that's a problem that was existing before.
Maybe a follow up task could be to mention these in the :ref:User Guide <text_feature_extraction> section of the User Guide instead of here. I would suggest to open an issue with a label for moderate difficulty for this, since this requires some more understanding of the topic.
What do you think, @adrinjalali?
|
Like the other example where we add a link to a specific section of the user guide instead, I think this makes sense here as well as @StefanieSenger suggests. So I'd suggest moving the list in a nicely iterated way to the user guide if it's not already there, and leave a link to that particular section here. That is, unless one of the examples tackles a specific constructor argument where a link to the example in that parameter makes sense. |
|
Hi @AnthonyPrudent! Would you like to continue working on this pull request? |
|
I am going to close this due to inactivity and because we have decided to close #30621. |
|
Re-opening, as this was reviewed and someone else may wish to continue |
marenwestermann
left a comment
There was a problem hiding this comment.
I updated the PR and addressed the comments. If the rendered docs look good and if the CI is green, I will merge.
|
Thank you for your work on this PR @AnthonyPrudent! |
Reference Issues/PRs
Towards #30621
What does this implement/fix? Explain your changes.
Added a link to plot_grid_search_text_feature_extraction.py in the API documentation under TfidfVectorizer.
Any other comments?