DOC merge plot_ward_structured_vs_unstructured and plot_agglomerative_clustering#30861
Conversation
There was a problem hiding this comment.
That looks good, thank you @mahmadza.
Basically, the examples are so similar, that we might want to join them later. But for now, I would merge this PR, since it is better to hint users to both usage examples than to only one, even if they don't differ so much.
@adrinjalali, what do you think about this?
|
They're almost the same example. I'd merge them in this PR. Would you be up for it @mahmadza ? You'd need to remove Line 438 in 6a2472f And remove all mentions of the old example from the codebase. |
|
Sure I can do that. To summarize what I need to do:
Let me know if my understanding is correct. |
…ctured_vs_unstructured
…d_vs_unstructured.py
…lot_ward_structured_vs_unstructured
|
@StefanieSenger @adrinjalali All requested changes have been completed. |
|
Hi @mahmadza, would you like to continue working on this pull request? |
@adrinjalali @marenwestermann sorry for the delay. |
|
I combined the examples. However, the figures from the former example "Agglomerative clustering with and without structure" still need to be combined into one figure so that the rendering in the user guide is correct. I will do that in the coming days. |
|
I updated this PR and addressed all the remaining comments. @adrinjalali can you give this one more review? I would like a second opinion before merging. |
Reference Issues/PRs
Towards #30621
What does this implement/fix? Explain your changes.
Added a link to structured vs unstructured ward hierarchical clustering example in
AgglomerativeClusteringclass.