Skip to content

DOC add example plot_stack_predictors.py for Stacked Generalization in ensemble.rst#30747

Merged
adrinjalali merged 1 commit intoscikit-learn:mainfrom
elhambbi:my_contribution
Feb 12, 2025
Merged

DOC add example plot_stack_predictors.py for Stacked Generalization in ensemble.rst#30747
adrinjalali merged 1 commit intoscikit-learn:mainfrom
elhambbi:my_contribution

Conversation

@elhambbi
Copy link
Copy Markdown
Contributor

@elhambbi elhambbi commented Feb 1, 2025

Reference Issues/PRs

#30621

What does this implement/fix? Explain your changes.

The exampleplot_stack_predictors.py is added to Stacked Generalization section in ensemble.rst in user guide.

Any other comments?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 7a33387. Link to the linter CI: here

StefanieSenger
StefanieSenger approved these changes Feb 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @elhambbi! It looks very good.

Can you please edit the title of your PR into something like DOC add example plot_stack_predictors.py for Stacked Generalization in ensemble.rst?

@marenwestermann @adrinjalali, can we merge this?

@StefanieSenger StefanieSenger mentioned this pull request Feb 2, 2025
Closed
@elhambbi elhambbi changed the title Towards #30621 added example plot_stack_predictors.py for Stacked Generalization in ensemble.rst Towards #30621 DOC add example plot_stack_predictors.py for Stacked Generalization in ensemble.rst Feb 2, 2025
@elhambbi
Copy link
Copy Markdown
Contributor Author

elhambbi commented Feb 2, 2025

Thank you for your contribution, @elhambbi! It looks very good.

Can you please edit the title of your PR into something like DOC add example plot_stack_predictors.py for Stacked Generalization in ensemble.rst?

@marenwestermann @adrinjalali, can we merge this?

Sure! I just changed the title of my PR.

@StefanieSenger
Copy link
Copy Markdown
Member

StefanieSenger commented Feb 4, 2025

Oh, I meant, can you please remove the "Towards #30621" from the title? I wasn't meant to be there.

@elhambbi elhambbi changed the title Towards #30621 DOC add example plot_stack_predictors.py for Stacked Generalization in ensemble.rst DOC add example plot_stack_predictors.py for Stacked Generalization in ensemble.rst Feb 4, 2025
@elhambbi
Copy link
Copy Markdown
Contributor Author

elhambbi commented Feb 4, 2025

Oh, I meant, can you please remove the "Towards #30621" from the title? I wasn't meant to be there.

Ah sorry for misunderstanding. I got it. It is fixed now. Thanks

@adrinjalali adrinjalali merged commit 20e10dd into scikit-learn:main Feb 12, 2025
4 checks passed
@StefanieSenger StefanieSenger mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@StefanieSenger StefanieSenger StefanieSenger approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elhambbi @StefanieSenger @adrinjalali