DOC add plot_ols_ridge_variance example to the doc#30683
DOC add plot_ols_ridge_variance example to the doc#30683adrinjalali merged 9 commits intoscikit-learn:mainfrom
Conversation
|
Thanks for your contribution, @sotagg! A concern that I would have is that the example on regression is listed below a part that treats classification. Two of the other examples listed there are also not dealing with What would you think of moving these three up into line 146 and making a new example section there? |
|
Thank you for the feedback, @StefanieSenger! I agree with your concern and have updated the documentation accordingly. |
StefanieSenger
left a comment
There was a problem hiding this comment.
That looks very good. Thank you @sotagg!
@marenwestermann @adrinjalali, would you like to merge this?
|
@sotagg thanks for the PR. As adding links to examples go, this is fine, but the example itself really needs some improvements. I think we can merge this example with |
|
Thanks for the suggestion, @adrinjalali! |
|
@adrinjalali |
adrinjalali
left a comment
There was a problem hiding this comment.
You also need to remove the plot_ols_ridge_variance.py file (you can do with git rm)
And then, yes, it makes sense to reference this from ridge as well probably.
examples/linear_model/plot_ols.py
Outdated
There was a problem hiding this comment.
you can remove this file now
|
@adrinjalali |
adrinjalali
left a comment
There was a problem hiding this comment.
Nice, this was missing redirects from the old examples, which I've added.
Reference Issues/PRs
#30621
What does this implement/fix? Explain your changes.
This PR adds a reference to the
plot_ols_ridge_variance.pyexample in the Ridge Regression section of the User Guide (linear_model.rst). This example demonstrates how Ridge regression reduces variance compared to OLS, making it relevant to this section.