DOC add read more tagline for contingency matrix metric#30666
DOC add read more tagline for contingency matrix metric#30666ArturoAmorQ merged 4 commits intoscikit-learn:mainfrom
Conversation
There was a problem hiding this comment.
Hello @santiviquez,
thanks for your PR. There are a few issues, but all in all adding this cross link is very valuable.
Hint: It is very advisable to have pre-commit installed in your environment as in point 10 of How to contribute in the development guide. This will help with future linting issues.
While being at this PR, can you please also correct the typo in line 118 ("continency matrix")? Thanks.
|
|
||
| Read more in the :ref:`User Guide <contingency-matrix>`. |
There was a problem hiding this comment.
| Read more in the :ref:`User Guide <contingency-matrix>`. | |
| Read more in the :ref:`User Guide <contingency_matrix>`. |
This should fix the linting issue (which is a mean one, because it's about the indent of the blank line).
Also, I have corrected the link.
|
Hi @santiviquez are you still working on this PR? |
|
Hi @ArturoAmorQ, sorry I forgot about this. I'll take care of it today. |
|
Everything should look better now. Thanks for the suggestions @StefanieSenger, and for the reminder @ArturoAmorQ :) |
StefanieSenger
left a comment
There was a problem hiding this comment.
Thank you for your further work, @santiviquez!
It looks very good now. :)
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Thanks @santiviquez this is a nice improvement. Merging!
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR adds the read more tagline for Contingency Matrix metric page. Which is currently missing.
Any other comments?