Skip to content

TST remove xfail marker for check_sample_weight_equivalence_on_dense_data and LinearRegression#30535

Merged
OmarManzoor merged 1 commit intoscikit-learn:mainfrom
ogrisel:remove-xfail-for-check_sample_weight_equivalence_on_dense_data-on-LinearRegression
Dec 24, 2024
Merged

TST remove xfail marker for check_sample_weight_equivalence_on_dense_data and LinearRegression#30535
OmarManzoor merged 1 commit intoscikit-learn:mainfrom
ogrisel:remove-xfail-for-check_sample_weight_equivalence_on_dense_data-on-LinearRegression

Conversation

@ogrisel
Copy link
Copy Markdown
Member

@ogrisel ogrisel commented Dec 23, 2024

This was fixed in #30040 for positive=False and passes for positive=True.

The sparse case is being concurrently handled in #30131 and the linked PR #30521.

@github-actions
Copy link
Copy Markdown

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e036616. Link to the linter CI: here

Copy link
Copy Markdown
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OmarManzoor OmarManzoor merged commit 970503f into scikit-learn:main Dec 24, 2024
@ogrisel ogrisel deleted the remove-xfail-for-check_sample_weight_equivalence_on_dense_data-on-LinearRegression branch December 30, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants