FIX proper inheritance for SGDOneClassSVM#30227
FIX proper inheritance for SGDOneClassSVM#30227adrinjalali merged 2 commits intoscikit-learn:mainfrom
Conversation
thomasjpfan
left a comment
There was a problem hiding this comment.
LGTM
Side note: In the past, I wanted to add a mixin order check to the common test, but I was unsure around running it on non scikit-learn estimators.
When adding the non-regression test, I had exactly this thought :). If we would have a fine grade test suite, we could have a categories for the estimators inheriting from our mixin and base estimator. Basically, even third-party will need this order of inheritance. |
adrinjalali
left a comment
There was a problem hiding this comment.
In terms of a common test, I think it should be in the API level anyway. At this point, if third parties don't inherit from our mixins, they really can't be compatible with us.
Fixes
mainThis pull request addresses an issue with the
SGDOneClassSVMclass in thesklearn.linear_modelmodule, ensuring it correctly inherits fromOutlierMixinand sets the appropriate tags. The most important changes include modifying the class inheritance, updating the documentation, and adding a new test to verify the correct estimator type.