DOC add link plot_inductive_clustering#30158
DOC add link plot_inductive_clustering#30158claudio1975 wants to merge 2 commits intoscikit-learn:mainfrom
Conversation
| :term:`inductive` clustering methods) are not designed to be applied to new, | ||
| unseen data. |
There was a problem hiding this comment.
This marks the key difference between Transductive and Inductive Clustering. Therefore, I think it should be preseverd.
virchan
left a comment
There was a problem hiding this comment.
Thank you for the PR @claudio1975! I have some suggestions. Otherwise, LGTM.
doc/modules/clustering.rst
Outdated
| :term:`inductive` clustering methods, refer to this example | ||
| :ref:`sphx_glr_auto_examples_cluster_plot_inductive_clustering.py`) are not | ||
| designed to be applied to new, unseen data. |
There was a problem hiding this comment.
I think the example link should be placed under a subsection. You can scroll down the document a bit to see how it's done for k_means, which is rendered as:
There was a problem hiding this comment.
Thank you too @virchan !!!
I agree, it's better to put the example outside the brackets. I've update the PR, and you can check it now -:)
virchan
left a comment
There was a problem hiding this comment.
Thank you for updating the PR! I have a few more suggestions. Additionally, please ensure that the CI tests are addressed afterward. Once that’s done, I can notify the other reviewers.
| :term:`inductive` clustering methods) are not | ||
| designed to be applied to new, unseen data. |
There was a problem hiding this comment.
| :term:`inductive` clustering methods) are not | |
| designed to be applied to new, unseen data. | |
| :term:`inductive` clustering methods) are not designed to be applied to new, | |
| unseen data. |
There was a problem hiding this comment.
Hi @virchan thanks for the suggestions.
I've seen yesterday that when I launched the updated PR, it started directly from the own repository instead from my fork repository.
I received the notifications about issues on the CI failed tests, and for instance I report the comment from the linter step:
""
Error: Unable to download artifact(s): Artifact not found for name: lint-log
Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
""
Maybe could come from not updated files in the own repository?
To avoid troubles, I close the pull request, I'll update my fork and local repository, and then I'll open a new one.
| * :ref:`sphx_glr_auto_examples_cluster_plot_inductive_clustering.py`: A practical | ||
| example of inductive clustering model. |
There was a problem hiding this comment.
| * :ref:`sphx_glr_auto_examples_cluster_plot_inductive_clustering.py`: A practical | |
| example of inductive clustering model. | |
| * :ref:`sphx_glr_auto_examples_cluster_plot_inductive_clustering.py`: An example | |
| of an inductive clustering model for handling new data. |
|
will follow a new one -#30182 |
What does this implement/fix? Explain your changes.
Added link plot_inductive_clustering -#26927