Skip to content

Plot kmeans plusplus#30126

Merged
adrinjalali merged 5 commits intoscikit-learn:mainfrom
natmokval:plot_kmeans_plusplus
Oct 29, 2024
Merged

Plot kmeans plusplus#30126
adrinjalali merged 5 commits intoscikit-learn:mainfrom
natmokval:plot_kmeans_plusplus

Conversation

@natmokval
Copy link
Copy Markdown
Contributor

original PR natmokval#1

Towards #26927

added links to examples in the docstrings and the user guide for K-Means ++.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 21, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 00d67dc. Link to the linter CI: here

@marenwestermann marenwestermann self-requested a review October 23, 2024 07:57
Copy link
Copy Markdown
Member

@marenwestermann marenwestermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment.

using :class:`KMeans` and :class:`MiniBatchKMeans` based on sparse data

* :ref:`sphx_glr_auto_examples_cluster_plot_kmeans_plusplus.py`: Using K-means++
to select seeds for other clustering algorithms.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation in this line is not correct (which causes the CI to fail).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for helping me. I corrected the indentation, now the CI is green.

Copy link
Copy Markdown
Member

@marenwestermann marenwestermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
ping @adrinjalali

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants