DOC merge example presenting the concept of validation curve by saldanhad · Pull Request #29936 · scikit-learn/scikit-learn

saldanhad · 2024-09-27T08:34:12Z

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Merged Plotting Validation Curves example with the Train error vs Test error example to simplify example under model_selection.

github-actions · 2024-09-27T08:35:30Z

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 5376ea2. Link to the linter CI: here}

ogrisel · 2024-09-27T13:24:46Z

Could you please update the redirects variable in doc/conf.py to make sure that the deleted example redirects to the merged example?

ogrisel · 2024-09-27T13:27:26Z

Also, please merge an updated version of the main branch into your validationcurve branch. You can either do that locally and push the result to your GitHub fork to get the PR updated, or click the "Update branch" in the GitHub user interface (and pull then the result locally if you plan to add further commits to your local branch).

…-learn into validationcurve

saldanhad · 2024-09-27T19:43:41Z

@ogrisel, Appreciate your help on this. Changes suggested are implemented and is now ready for review. Thank you!

saldanhad · 2024-09-28T10:10:22Z

Hi @ogrisel, Since we are merging the train vs test error with validation curves, do you think it would be good to have the navigation link as Train vs Test error and Validation Curves or is it better as is?

…-learn into validationcurve

examples/model_selection/plot_train_error_vs_test_error_and_validation_curve.py

doc/conf.py

examples/model_selection/plot_train_error_vs_test_error.py

examples/model_selection/plot_train_error_vs_test_error_and_validation_curve.py

…-learn into validationcurve

saldanhad · 2024-10-08T07:09:29Z

RFR @glemaitre

…and model

glemaitre

I pushed a commit that:

improve the entire narration
change the model parameters to better show the trade-off underfit/overfit

I'll wait for the CI to check the rendering.

merge validation curve and traintest_error

f3f8a41

github-actions bot added the Documentation label Sep 27, 2024

saldanhad changed the title ~~DOC: Merge train v test error with plotin validation curve example~~ DOC: Merge train v test error with ploting validation curve example Sep 27, 2024

saldanhad added 2 commits September 27, 2024 14:15

fix linting

5b947b7

Merge remote-tracking branch 'upstream/main' into validationcurve

cf00542

saldanhad marked this pull request as draft September 27, 2024 15:48

saldanhad and others added 3 commits September 27, 2024 21:19

Merge branch 'main' into validationcurve

a9d9de5

Merge branch 'validationcurve' of https://github.com/saldanhad/scikit…

f1cf615

…-learn into validationcurve

update redirects in conf.py

30cfdb8

saldanhad marked this pull request as ready for review September 27, 2024 17:18

Merge branch 'main' into validationcurve

27cf5ce

rename file, reflecting change

9cff844

saldanhad marked this pull request as draft September 28, 2024 10:09

saldanhad and others added 3 commits September 29, 2024 02:01

Merge branch 'main' into validationcurve

07286ae

update link in conf.py

d794f2e

Merge branch 'validationcurve' of https://github.com/saldanhad/scikit…

fd636fe

…-learn into validationcurve

saldanhad marked this pull request as ready for review September 28, 2024 20:36

glemaitre self-requested a review September 29, 2024 16:38