DOC added links for plot_affinity_propagation.py#29759
Merged
adrinjalali merged 8 commits intoscikit-learn:mainfrom Oct 17, 2024
Merged
DOC added links for plot_affinity_propagation.py#29759adrinjalali merged 8 commits intoscikit-learn:mainfrom
adrinjalali merged 8 commits intoscikit-learn:mainfrom
Conversation
marenwestermann
requested changes
Sep 8, 2024
Member
marenwestermann
left a comment
There was a problem hiding this comment.
Just a small comment. Otherwise LGTM.
| For an example, see :ref:`examples/cluster/plot_affinity_propagation.py | ||
| <sphx_glr_auto_examples_cluster_plot_affinity_propagation.py>`. | ||
| For an example usage, | ||
| see :ref:`sphx_glr_auto_examples_cluster_plot_affinity_propagation.py`. |
Member
There was a problem hiding this comment.
I would also mention this example here: https://scikit-learn.org/stable/auto_examples/applications/plot_stock_market.html#clustering-using-affinity-propagation
Contributor
Author
There was a problem hiding this comment.
I have added the example, and rebased the branch.
Member
|
Can you pull the changes from upstream main into your branch? It should fix the CI failures. |
marenwestermann
approved these changes
Sep 22, 2024
Member
marenwestermann
left a comment
There was a problem hiding this comment.
LGTM
ping @adrinjalali
adrinjalali
approved these changes
Oct 17, 2024
Member
|
@ivanpan0626 in the future please make sure you create a feature branch locally instead of working on your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
issue #26927
What does this implement/fix? Explain your changes.
Added example links for plot_affinity_propagation.py
Added example links for plot_dbscan.py
Any other comments?