TST move check_class_weight_balanced_linear_classifier to estimator checks#29712
Merged
glemaitre merged 5 commits intoscikit-learn:mainfrom Sep 3, 2024
Conversation
…balanced_linear_classifier
OmarManzoor
approved these changes
Aug 27, 2024
Contributor
OmarManzoor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @adrinjalali
From the diff it looks the this check was already present in the estimator checks. Was it not enabled previously?
adrinjalali
commented
Aug 27, 2024
Comment on lines
+187
to
+189
| if isinstance(classifier, LinearClassifierMixin): | ||
| if "class_weight" in classifier.get_params().keys(): | ||
| yield check_class_weight_balanced_linear_classifier |
Member
Author
There was a problem hiding this comment.
@OmarManzoor
yes, the test was present in this file, but not a part of check_estimator function or parametrize_with_checks. So for third party estimators this was not enabled, and our estimators also wouldn't be able to skip it with _xfail_checks. This moves it here like all the other tests.
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Member
|
Thanks @adrinjalali. Enabling auto-merge. I might need to come back in case we still have the failure with 32-bits debian build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves
check_class_weight_balanced_linear_classifierto estimator checks.cc @glemaitre @OmarManzoor