:lock: :robot: CI Update lock files for main CI build(s) :lock: :robot: by scikit-learn-bot · Pull Request #29486 · scikit-learn/scikit-learn

scikit-learn-bot · 2024-07-15T05:08:07Z

Update lock files.

Note

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

github-actions · 2024-07-15T05:09:22Z

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 4650e75. Link to the linter CI: here}

lesteve · 2024-07-15T09:09:10Z

The doc-min-dependencies failure is known see #29300 (comment)

adrinjalali · 2024-07-15T09:48:05Z

@EmilyXinyi @OmarManzoor would be nice to fix the issue for this PR, so that our CI passes on main again.

adrinjalali · 2024-07-19T11:06:03Z

CI timed out, microsoft outage related? Restarted the CI.

adrinjalali · 2024-07-19T14:17:41Z

🤦🏼 the tests timeout around 91% done.

lesteve · 2024-07-19T14:27:53Z

Oh well, maybe we can wait until Monday morning and hope it disappear when the bot regenerates the lock-files ...

adrinjalali · 2024-07-19T14:43:39Z

Yeah, so closing this one and we'll see on monday.

lesteve · 2024-07-19T14:50:56Z

Actually it's better to leave it open this way the bot will reuse this PR (it force-pushes into the branch) and the context with the weird no-OpenMP timeout will be here (in case the timeout hasn't disappeared) 😉

lesteve · 2024-07-22T08:15:54Z

So the no-OpenMP build still times out ... from the diff Meson 1.5 could be the culprit maybe 🤔 ...

One thing that is weird is that OpenMP is now detected in the no-OpenMP build, so at the very least this build does not serve its purpose and needs to be adapted. Probably this as a side-effect of mesonbuild/meson#13350, see
see build log

Built with OpenMP: True

adrinjalali · 2024-07-22T09:38:13Z

So should we open a meson issue? really hard to reproduce/diagnose though.

lesteve · 2024-07-22T12:34:10Z

So should we open a meson issue? really hard to reproduce/diagnose though.

I pinned meson<1.5 to double-check meson 1.5 is the culprit. If the timeout is gone with meson<1.5, I guess someone with a macOS machine should try to have a closer look ...

lesteve · 2024-07-22T14:44:35Z

So in the latest commit with meson 1.4.2 the CI pass, so I guess this is tied to Meson 1.5 ...

lesteve · 2024-07-22T15:13:53Z

The pip-latest-openblas-pandas issue seems like a regression in pytest 8.3.1, I opened pytest-dev/pytest#12650 about it ...

pytest --doctest-modules sklearn/utils/tests/test_deprecation.py

works fine with pytest 8.2.2 and fails with 8.3.1:

❯ pytest --doctest-modules sklearn/utils/tests/test_deprecation.py
=================================================================================================================================================== test session starts ===================================================================================================================================================
platform linux -- Python 3.11.9, pytest-8.3.1, pluggy-1.5.0
rootdir: /home/lesteve/dev/scikit-learn
configfile: setup.cfg
plugins: xdist-3.6.1, cov-5.0.0
collected 3 items / 1 error                                                                                                                                                                                                                                                                                               

========================================================================================================================================================= ERRORS ==========================================================================================================================================================
________________________________________________________________________________________________________________________________ ERROR collecting sklearn/utils/tests/test_deprecation.py _________________________________________________________________________________________________________________________________
../../micromamba/envs/scikit-learn-pip-openblas/lib/python3.11/doctest.py:942: in find
    self._find(tests, obj, name, module, source_lines, globs, {})
../../micromamba/envs/scikit-learn-pip-openblas/lib/python3.11/doctest.py:1016: in _find
    self._find(tests, val, valname, module, source_lines,
../../micromamba/envs/scikit-learn-pip-openblas/lib/python3.11/doctest.py:1048: in _find
    self._find(tests, val, valname, module, source_lines,
../../micromamba/envs/scikit-learn-pip-openblas/lib/python3.11/doctest.py:1004: in _find
    test = self._get_test(obj, name, module, globs, source_lines)
../../micromamba/envs/scikit-learn-pip-openblas/lib/python3.11/doctest.py:1072: in _get_test
    lineno = self._find_lineno(obj, source_lines)
../../micromamba/envs/scikit-learn-pip-openblas/lib/python3.11/doctest.py:1121: in _find_lineno
    obj = inspect.unwrap(obj).__code__
E   AttributeError: 'property' object has no attribute '__code__'
================================================================================================================================================= short test summary info =================================================================================================================================================
ERROR sklearn/utils/tests/test_deprecation.py - AttributeError: 'property' object has no attribute '__code__'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
==================================================================================================================================================== 1 error in 0.17s =====================================================================================================================================================

lesteve

LGTM.

Since sphinx-gallery was updated I quickly checked the examples gallery coming from a previous commit doc build and this looks fine.

I opened #29546 to track the timeout in the no-OpenMP build with Meson 1.5.

adrinjalali

Thanks @lesteve

Co-authored-by: Lock file bot <noreply@github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com>

scikit-learn-bot force-pushed the auto-update-lock-files-main branch from 8efbaeb to eb2b9e7 Compare July 15, 2024 05:08

github-actions Bot added the Build / CI label Jul 15, 2024

lesteve force-pushed the auto-update-lock-files-main branch from eb2b9e7 to dcabeb3 Compare July 19, 2024 08:32

adrinjalali closed this Jul 19, 2024

lesteve reopened this Jul 19, 2024

Update CI lock files [doc build]

067a63a

scikit-learn-bot force-pushed the auto-update-lock-files-main branch from dcabeb3 to 067a63a Compare July 22, 2024 05:08

lesteve added 2 commits July 22, 2024 14:32

pin meson<1.5 in no-OpenMP build to avoid timeout

abb9f28

[azure parallel]

cd81c19

lesteve mentioned this pull request Jul 22, 2024

Regression in pytest 8.3.1: AttributeError: 'property' object has no attribute '__code__' on Python 3.11 when combining doctest with property decoration pytest-dev/pytest#12650

Closed

4 tasks

[azure parallel] fix wrapping for pytest 8.3.1

4650e75

lesteve approved these changes Jul 23, 2024

View reviewed changes

lesteve mentioned this pull request Jul 23, 2024

CI Investigate timeout in no-OpenMP build with Meson 1.5 #29546

Closed

adrinjalali approved these changes Jul 23, 2024

View reviewed changes

adrinjalali merged commit 8133eca into scikit-learn:main Jul 23, 2024

glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Sep 9, 2024

🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 (scikit-learn#29486)

896b451

Co-authored-by: Lock file bot <noreply@github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com>

glemaitre added a commit that referenced this pull request Sep 11, 2024

🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 (#29486)

f96bfc2

Co-authored-by: Lock file bot <noreply@github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com>

Uh oh!

Conversation

scikit-learn-bot commented Jul 15, 2024

Note

Uh oh!

github-actions Bot commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✔️ Linting Passed

Uh oh!

lesteve commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adrinjalali commented Jul 15, 2024

Uh oh!

adrinjalali commented Jul 19, 2024

Uh oh!

adrinjalali commented Jul 19, 2024

Uh oh!

lesteve commented Jul 19, 2024

Uh oh!

adrinjalali commented Jul 19, 2024

Uh oh!

lesteve commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lesteve commented Jul 22, 2024

Uh oh!

adrinjalali commented Jul 22, 2024

Uh oh!

lesteve commented Jul 22, 2024

Uh oh!

lesteve commented Jul 22, 2024

Uh oh!

lesteve commented Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lesteve left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adrinjalali left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jul 15, 2024 •

edited

Loading

lesteve commented Jul 15, 2024 •

edited

Loading

lesteve commented Jul 19, 2024 •

edited

Loading

lesteve commented Jul 22, 2024 •

edited

Loading

lesteve left a comment •

edited

Loading