ENH Array API support for euclidean_distances and rbf_kernel by OmarManzoor · Pull Request #29433 · scikit-learn/scikit-learn

OmarManzoor · 2024-07-08T12:45:49Z

Reference Issues/PRs

Towards #26024

What does this implement/fix? Explain your changes.

Adds array api support for euclidean_distances and rbf_kernel

Any other comments?

github-actions · 2024-07-08T12:47:05Z

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 526d932. Link to the linter CI: here}

OmarManzoor · 2024-07-09T07:24:10Z

@ogrisel Don't we have the latest version of array api strict on all CI pipelines? This seems to be failing for some pipelines probably because of the older version of array-api-strict, while it works fine on my local system with the latest version of array-api-strict. Should we fix this just for supporting an old version?

sklearn/metrics/pairwise.py

ogrisel · 2024-07-09T09:15:23Z

@OmarManzoor let me update this PR with main after the merge of #29388.

Further CI fixes will follow-up once #29436 is reviewed and merged.

OmarManzoor · 2024-07-09T10:52:51Z

@ogrisel These CI errors seem a bit weird. One is related to the docstring of get_namespace_and_device. The other error is related to a casting issue which does not occur on my local system. Edit: I see that the second error is in a docstring. I am checking it.

sklearn/metrics/pairwise.py

sklearn/utils/_array_api.py

sklearn/utils/extmath.py

ogrisel · 2024-07-09T13:56:48Z

I thought I fixed that docstring failure somewhere else already.

EDIT: here it is:

https://github.com/scikit-learn/scikit-learn/pull/29318/files#diff-6264adab84df6fafdb2d950141783b52b718da1e1be773daae7b5921b2556f94R572

@OmarManzoor feel free to steal this from the Ridge PR since I won't have time to finalize it this week.

ogrisel · 2024-07-09T16:15:23Z

Please feel free to merge main into this branch to benefit from the fixes in #29436.

ogrisel

I labeled "CUDA CI" to trigger a CI run with a CUDA GPU.

If everything is green, LGTM.

sklearn/metrics/pairwise.py

doc/modules/array_api.rst

sklearn/utils/_array_api.py

sklearn/utils/tests/test_array_api.py

ogrisel · 2024-07-10T14:58:20Z

I tried to relabel this PR to trigger the CUDA CI out of curiosity but it's still waiting on workers for some unknown reason:

https://github.com/scikit-learn/scikit-learn/actions/workflows/cuda-gpu-ci.yml

adrinjalali

Otherwise LGTM. Thanks @ogrisel for the ping.

sklearn/metrics/pairwise.py

adrinjalali

LGTM. I'll let @ogrisel have another look and merge.

OmarManzoor · 2024-07-11T14:46:31Z

@ogrisel Can this be merged?

sklearn/utils/_array_api.py

OmarManzoor added 2 commits July 8, 2024 17:07

ENH Array API support for euclidean_distances and rbf_kernel

e611758

Fix for cupy.array_api

ba092bd

github-actions bot added module:metrics module:utils labels Jul 8, 2024

ogrisel added the Array API label Jul 8, 2024

Add alternative for np.dot and add rbf kernel

ab46fec

OmarManzoor added 2 commits July 9, 2024 12:37

Remove tensordot

191e29b

Merge branch 'main' into array_api_euclidean_distances_rbf_kernel

7fa28e2

OmarManzoor commented Jul 9, 2024

View reviewed changes

sklearn/metrics/pairwise.py Outdated Show resolved Hide resolved

ogrisel and others added 5 commits July 9, 2024 11:15

Merge branch 'main' into array_api_euclidean_distances_rbf_kernel

a7dc716

Retain in-place operations where possible

5a4f031

Add changelog

fcaaa64

Add pr number

3aae9d2

Improve _xp_method_has_out

d07865f

Fix for dtype in zero definition

f8f75b1

ogrisel reviewed Jul 9, 2024

View reviewed changes

sklearn/metrics/pairwise.py Outdated Show resolved Hide resolved

sklearn/metrics/pairwise.py Outdated Show resolved Hide resolved

sklearn/utils/_array_api.py Outdated Show resolved Hide resolved

sklearn/utils/extmath.py Outdated Show resolved Hide resolved

OmarManzoor added 3 commits July 10, 2024 12:53

Merge branch 'main' into array_api_euclidean_distances_rbf_kernel

c2290fb

Updates: according to PR suggestions

41118c7

Minor change in docstring

6deb173

ogrisel added the CUDA CI label Jul 10, 2024

ogrisel approved these changes Jul 10, 2024

View reviewed changes

ogrisel reviewed Jul 10, 2024

View reviewed changes

sklearn/metrics/pairwise.py Show resolved Hide resolved

ogrisel reviewed Jul 10, 2024

View reviewed changes

doc/modules/array_api.rst Outdated Show resolved Hide resolved

Fix docstring

3145042

OmarManzoor added 3 commits July 10, 2024 15:02

Remove maximum from array api wrapper

e67ddd3

Add device float support section

a1715f4

Add the maximum function back along with a test

d43931a

ogrisel reviewed Jul 10, 2024

View reviewed changes

doc/modules/array_api.rst Outdated Show resolved Hide resolved

OmarManzoor added 3 commits July 10, 2024 19:10

Updates: further suggestions

8318e56

Add tests for fill_or_add_to_diagonal

074a0f1

Merge branch 'main' into array_api_euclidean_distances_rbf_kernel

363aaef

ogrisel reviewed Jul 10, 2024

View reviewed changes

sklearn/utils/_array_api.py Show resolved Hide resolved

sklearn/utils/tests/test_array_api.py Show resolved Hide resolved

Minor change in docstring

6fc5a0b

ogrisel added CUDA CI and removed CUDA CI labels Jul 10, 2024

adrinjalali reviewed Jul 11, 2024

View reviewed changes

sklearn/metrics/pairwise.py Outdated Show resolved Hide resolved

sklearn/metrics/pairwise.py Outdated Show resolved Hide resolved

OmarManzoor added 4 commits July 11, 2024 13:09

Further updates: based on PR review

ead6ea8

Further updates: based on PR review

63f1242

Update TODO statement

3499bcf

Merge branch 'main' into array_api_euclidean_distances_rbf_kernel

2eec496

adrinjalali approved these changes Jul 11, 2024

View reviewed changes

ogrisel approved these changes Jul 11, 2024

View reviewed changes

sklearn/utils/_array_api.py Outdated Show resolved Hide resolved

Improve error message.

68b1467

ogrisel enabled auto-merge (squash) July 11, 2024 14:51

OmarManzoor added 2 commits July 11, 2024 19:55

Merge branch 'main' into array_api_euclidean_distances_rbf_kernel

7073aad

Fix linting

526d932

ogrisel merged commit e7af195 into scikit-learn:main Jul 11, 2024

OmarManzoor deleted the array_api_euclidean_distances_rbf_kernel branch July 11, 2024 15:58

EmilyXinyi mentioned this pull request Aug 14, 2024

Add array API support for Nystroem approximation #29661

Merged

5 tasks

betatim mentioned this pull request Aug 30, 2024

Make more of the "tools" of scikit-learn Array API compatible #26024

Open

lesteve mentioned this pull request Jun 3, 2025

Fix _fill_or_add_to_diagonal when reshape returns copy #31445

Merged

jeremiedbb mentioned this pull request Jul 27, 2025

DOC Add note in Array API doc regarding support for devices without float 64 support #28034

Closed

Uh oh!

Conversation

OmarManzoor commented Jul 8, 2024

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Uh oh!

github-actions bot commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✔️ Linting Passed

Uh oh!

OmarManzoor commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ogrisel commented Jul 9, 2024

Uh oh!

OmarManzoor commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ogrisel commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ogrisel commented Jul 9, 2024

Uh oh!

ogrisel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ogrisel commented Jul 10, 2024

Uh oh!

adrinjalali left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

adrinjalali left a comment

Choose a reason for hiding this comment

Uh oh!

OmarManzoor commented Jul 11, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jul 8, 2024 •

edited

Loading

OmarManzoor commented Jul 9, 2024 •

edited

Loading

OmarManzoor commented Jul 9, 2024 •

edited

Loading

ogrisel commented Jul 9, 2024 •

edited

Loading