Skip to content

TST Fix doctests to be compatible with scipy>=1.14#29385

Closed
lesteve wants to merge 2 commits intoscikit-learn:mainfrom
lesteve:fix-scipy-1.14-doctest
Closed

TST Fix doctests to be compatible with scipy>=1.14#29385
lesteve wants to merge 2 commits intoscikit-learn:mainfrom
lesteve:fix-scipy-1.14-doctest

Conversation

@lesteve
Copy link
Copy Markdown
Member

@lesteve lesteve commented Jul 2, 2024

Seen in #29276,

Scipy 1.14 tweaked the sparse matrix __repr__ making a few of our doctests fail.

This is only running the doctests for scipy>=1.14 following what we already do with numpy (we are currently running the doctests only with numpy<2 actually, we should probably update this to only run them with numpy>=2).

This is tested locally and will not be tested in the CI until we fix #29276.

@lesteve lesteve changed the title Fix scipy 1.14 doctest TST Fix doctests to be compatible with scipy>=1.14 Jul 2, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 1e63b2b. Link to the linter CI: here

@lesteve
Copy link
Copy Markdown
Member Author

lesteve commented Jul 3, 2024

Closing in favour of #29388

@lesteve lesteve closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant