Skip to content

MAINT Use Pyodide venv rather than js wrapper script#29156

Closed
lesteve wants to merge 7 commits intoscikit-learn:mainfrom
lesteve:pyodide-venv
Closed

MAINT Use Pyodide venv rather than js wrapper script#29156
lesteve wants to merge 7 commits intoscikit-learn:mainfrom
lesteve:pyodide-venv

Conversation

@lesteve
Copy link
Member

@lesteve lesteve commented Jun 2, 2024 •
edited
Loading

The issue with library loading in Pyodide with scipy.linalg may have gone away pyodide/pyodide#3865 (comment). Let's see what CI has to say about this ...

@lesteve lesteve mentioned this pull request Jun 2, 2024
Closed
@github-actions
Copy link

github-actions bot commented Jun 2, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 07392c7. Link to the linter CI: here

@lesteve
Copy link
Member Author

lesteve commented Jun 2, 2024 •
edited
Loading

Getting the cannot resolve symbol s_cmp with Pyodide 0.25.1, same thing as in scikit-image scikit-image/scikit-image#7350 (comment). Edit: same issue with Pyodide 0.26.0:

Error: Dynamic linking error: cannot resolve symbol s_cmp
    at stubs.<computed> (/home/vsts/work/1/s/.pyodide-xbuildenv/xbuildenv/pyodide-root/dist/pyodide.asm.js:9:144885)
    at wasm://wasm/0003b6da:wasm-function[80]:0x280c
    at wasm://wasm/0003b6da:wasm-function[75]:0x1c0e
    at wasm://wasm/0003d766:wasm-function[109]:0xbb94
    at _PyEM_TrampolineCall_JS (/home/vsts/work/1/s/.pyodide-xbuildenv/xbuildenv/pyodide-root/dist/pyodide.asm.js:9:120223)
    at wasm://wasm/02257296:wasm-function[1083]:0x1a3494
    at wasm://wasm/02257296:wasm-function[1091]:0x1a3a86
    at wasm://wasm/02257296:wasm-function[3226]:0x26a798
    at wasm://wasm/02257296:wasm-function[3227]:0x26e800
    at wasm://wasm/02257296:wasm-function[1096]:0x1a3e08

@lesteve lesteve mentioned this pull request Jun 5, 2024
Merged
@lesteve lesteve closed this Jun 11, 2024
@agriyakhetarpal agriyakhetarpal mentioned this pull request Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lesteve